[PATCH] D32450: [libunwind] Add 64-bit SPARC support

[Joerg Sonnenberger via Phabricator via llvm-commits]

joerg added inline comments.


================
Comment at: libunwind/src/DwarfParser.hpp:659
+      _LIBUNWIND_TRACE_DWARF("DW_CGA_GNU_window_save\n");
       break;
     case DW_CFA_GNU_args_size:
----------------
compnerd wrote:
> Is the `DW_CFA_GNU_window_save` operand limited to SPARC?  I think that we should handle this generically, not specific to SPARC.  We can add a special case for SPARC if the generic way to handle windows registers doesn't work.
Yes. It only makes sense on architectures with register windows and that essentially means SPARC. See the NetBSD version which goes as far as excluding the code for !sparc.


https://reviews.llvm.org/D32450