[PATCH] D32452: [git-llvm] Make `push` work on CRLF files with svn:eol-style=native

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 24 14:38:59 PDT 2017


rnk added a comment.

In https://reviews.llvm.org/D32452#735996, @zturner wrote:

> There are certain files in the repo that absolutely must be CRLF, and are documented as such.  So this patch would break those files.  I'm not sure if that's a problem though.


It won't, because those files will not set svn:eol-style to native. The ones I know of in the clangd test directory explicitly set svn:eol-style to CRLF, or don't set it at all.

> Can we just wash our hands of this added complexity and globally remove this property?  We've been doing it on a file-by-file basis for months, and nobody has noticed or complained

I'd rather do this, and hope it works well enough that we can survive until the git migration.


https://reviews.llvm.org/D32452





More information about the llvm-commits mailing list