[PATCH] D32447: Update profile during memory instrinsic optimization

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 24 11:53:15 PDT 2017


tejohnson added inline comments.


================
Comment at: lib/Transforms/Instrumentation/IndirectCallPromotion.cpp:955
   MergeBB->setName("MemOP.Merge");
+  // Set the block frequency on the MergeBB, since it contains the
+  // remainder of the original BB, and may contain additional mem ops
----------------
davidxl wrote:
> This comment seems unnecessary :) Also can you move the DefaultBB setting after MergeBB update?
Sure. I mostly added the comment to indicate why it was important to update the MergeBB profile frequency specifically (and not the other new BBs), but can remove it.


https://reviews.llvm.org/D32447





More information about the llvm-commits mailing list