[PATCH] D31987: [SDAG] Teach Chain Analysis about BaseIndexOffset addressing.

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D31987#732491, @niravd wrote:

> Yes. This should fully encompass the Base check and we should be able to repoint the relevant additional checks for globals/constants and framepointers to the baseindex check. I have a follow up patch that should completely remove findBaseOffset and do the incremental checks for FramePointers etc. off of the BaseIndexOffset match which should be correct (though I need to do a more thorough check to be more sure). I kept if off here to make it clearer that this is just adding the BaseIndexOffset case analysis to our current BaseOffset check and not dropping any cases.


In that case, can you add a 'FIXME' comment describing this plan as part of this patch. Just in case the follow-ups are delayed for some reason, we don't want to leave this code in a confusing state.
Given that, LGTM. But if anyone else can also give this a look, that would be best since I'm not that familiar with all of the aliasing possibilities.


https://reviews.llvm.org/D31987