[PATCH] D32215: Updated PPCG Code Generation for OpenCL compatibility

Mon Apr 24 02:36:01 PDT 2017

grosser added a comment.

Hi Philippe,

one comment regarding the data-layout changes:

================
Comment at: test/GPGPU/double-parallel-loop.ll:215
 ;
-target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v16:16:16-v32:32:32-v64:64:64-v128:128:128-n16:32:64"

----------------
Hi Philippe,

I am slightly surprised you change the data-layout of the input code. This is generally nothing we have control over. Is this change indeed needed to make your patch work?

Repository:
  rL LLVM

https://reviews.llvm.org/D32215