[PATCH] D32120: Don't test setting sticky bits on files for (Free|Open)BSD

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 22 11:51:36 PDT 2017


krytarowski added a comment.

In https://reviews.llvm.org/D32120#734634, @emaste wrote:

> In https://reviews.llvm.org/D32120#734603, @krytarowski wrote:
>
> > I don't agree. It would mean that it's supposed to work on BSD4.4 and derivate systems like BSD/OS.
>
>
> I think it would be useful to have a #define for modern BSDs though, as presumably DragonFly, bitrig, EdgeBSD etc. will need it set as well (although some/all may still include the #define inherited from their parent).


I support automatic detection of features in configure time rather than ifdefing. Haiku, Minix, Darwin are close to BSD and they perhaps shouldn't be in the category of BSD, while they share similar interfaces.


https://reviews.llvm.org/D32120





More information about the llvm-commits mailing list