[PATCH] D32387: [PartialInlining] Add Optimization Remark Support

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 22 11:38:34 PDT 2017


davide added inline comments.


================
Comment at: lib/Transforms/IPO/PartialInlining.cpp:32
 
-#define DEBUG_TYPE "partialinlining"
+#define DEBUG_TYPE "partial_inlining"
 
----------------
Any reason to change the `DEBUG_TYPE` ?


================
Comment at: lib/Transforms/IPO/PartialInlining.cpp:70-72
+  if (F->hasAddressTaken())
+    return nullptr;
+
----------------
Feel free to commit this separately now (before the review)


https://reviews.llvm.org/D32387





More information about the llvm-commits mailing list