[PATCH] D32353: [LoopSimplify] Simplify constant conditional branches to unconditional branches

Anna Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 21 15:40:07 PDT 2017


anna abandoned this revision.
anna added a comment.

Thanks for the comments, Eli. As proven, the implicit assumption that loops won't be removed is not true.  I had a chat with Chandler on IRC, and his suggestion was to merge the loop-deletion pass and loop-simplifyCFG (loop deletion is a form of simplifyCFG for loop). 
Effectively, when we change branches to unconditional, we will be deleting loops in someway or another:

1. a subloop becomes unreachable, i.e. a branch to the header is removed.
2. a parent loop is a non-loop because it's backedge is removed.

Abandoning this revision, since this requires major rework from current state.


https://reviews.llvm.org/D32353





More information about the llvm-commits mailing list