[PATCH] D32373: [PartialInliner] Do not do partial inlining for functions with non-call references

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 21 15:21:54 PDT 2017


yep, that looks better.

David

On Fri, Apr 21, 2017 at 2:56 PM, Eli Friedman via Phabricator <
reviews at reviews.llvm.org> wrote:

> efriedma added inline comments.
>
>
> ================
> Comment at: llvm/trunk/lib/Transforms/IPO/PartialInlining.cpp:104
> +
> +  if (!canAllUsesBeReplaced(F))
> +    return nullptr;
> ----------------
> Can you just call Function::hasAddressTaken instead?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D32373
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170421/00816a0f/attachment.html>


More information about the llvm-commits mailing list