[llvm] r301012 - Revert r301010: Bot failures on Windows, NetBSD and even some old Darwin.

[Kuba Mracek via llvm-commits]

Author: kuba.brecka
Date: Fri Apr 21 13:02:22 2017
New Revision: 301012

URL: http://llvm.org/viewvc/llvm-project?rev=301012&view=rev
Log:
Revert r301010: Bot failures on Windows, NetBSD and even some old Darwin.


Modified:
    llvm/trunk/lib/Fuzzer/CMakeLists.txt

Modified: llvm/trunk/lib/Fuzzer/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/CMakeLists.txt?rev=301012&r1=301011&r2=301012&view=diff
==============================================================================
--- llvm/trunk/lib/Fuzzer/CMakeLists.txt (original)
+++ llvm/trunk/lib/Fuzzer/CMakeLists.txt Fri Apr 21 13:02:22 2017
@@ -11,14 +11,17 @@ if( NOT HAS_THREAD_LOCAL )
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Dthread_local=__thread")
 endif()
 
+set(LIBFUZZER_FLAGS_BASE "${CMAKE_CXX_FLAGS}")
+# Disable the coverage and sanitizer instrumentation for the fuzzer itself.
+set(CMAKE_CXX_FLAGS "${LIBFUZZER_FLAGS_BASE} -fno-sanitize-coverage=trace-pc-guard,edge,trace-cmp,indirect-calls,8bit-counters -Werror")
 if( LLVM_USE_SANITIZE_COVERAGE )
-  set(LIBFUZZER_FLAGS_BASE "${CMAKE_CXX_FLAGS}")
-
-  # Disable the coverage and sanitizer instrumentation for the fuzzer itself.
-  set(CMAKE_CXX_FLAGS "${LIBFUZZER_FLAGS_BASE} -fno-sanitize-coverage=trace-pc-guard,edge,trace-cmp,indirect-calls,8bit-counters -Werror")
-endif()
-
-add_library(LLVMFuzzerNoMainObjects OBJECT
+  if(NOT "${LLVM_USE_SANITIZER}" STREQUAL "Address")
+    message(FATAL_ERROR
+      "LibFuzzer and its tests require LLVM_USE_SANITIZER=Address and "
+      "LLVM_USE_SANITIZE_COVERAGE=YES to be set."
+      )
+  endif()
+  add_library(LLVMFuzzerNoMainObjects OBJECT
     FuzzerCrossOver.cpp
     FuzzerDriver.cpp
     FuzzerExtFunctionsDlsym.cpp
@@ -42,24 +45,15 @@ add_library(LLVMFuzzerNoMainObjects OBJE
     FuzzerUtilPosix.cpp
     FuzzerUtilWindows.cpp
     )
-add_library(LLVMFuzzerNoMain STATIC
+  add_library(LLVMFuzzerNoMain STATIC
     $<TARGET_OBJECTS:LLVMFuzzerNoMainObjects>
     )
-target_link_libraries(LLVMFuzzerNoMain ${LLVM_PTHREAD_LIB})
-add_library(LLVMFuzzer STATIC
+  target_link_libraries(LLVMFuzzerNoMain ${LLVM_PTHREAD_LIB})
+  add_library(LLVMFuzzer STATIC
     FuzzerMain.cpp
     $<TARGET_OBJECTS:LLVMFuzzerNoMainObjects>
     )
-target_link_libraries(LLVMFuzzer ${LLVM_PTHREAD_LIB})
-
-if( LLVM_USE_SANITIZE_COVERAGE )
-
-  if(NOT "${LLVM_USE_SANITIZER}" STREQUAL "Address")
-    message(FATAL_ERROR
-      "LibFuzzer tests require LLVM_USE_SANITIZER=Address and "
-      "LLVM_USE_SANITIZE_COVERAGE=YES to be set."
-      )
-  endif()
+  target_link_libraries(LLVMFuzzer ${LLVM_PTHREAD_LIB})
 
   if( LLVM_INCLUDE_TESTS )
     add_subdirectory(test)