[PATCH] D32359: [tsan] Track external API accesses as 1-byte accesses (instead of 8-byte)

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 21 10:24:35 PDT 2017


kubamracek created this revision.
kubamracek added a project: Sanitizers.

It doesn't really make sense to track them as 8-byte accesses.


Repository:
  rL LLVM

https://reviews.llvm.org/D32359

Files:
  lib/tsan/rtl/tsan_external.cc


Index: lib/tsan/rtl/tsan_external.cc
===================================================================
--- lib/tsan/rtl/tsan_external.cc
+++ lib/tsan/rtl/tsan_external.cc
@@ -58,7 +58,7 @@
   ThreadState *thr = cur_thread();
   thr->external_tag = (uptr)tag;
   FuncEntry(thr, (uptr)caller_pc);
-  MemoryRead(thr, CALLERPC, (uptr)addr, kSizeLog8);
+  MemoryRead(thr, CALLERPC, (uptr)addr, kSizeLog1);
   FuncExit(thr);
   thr->external_tag = 0;
 }
@@ -69,7 +69,7 @@
   ThreadState *thr = cur_thread();
   thr->external_tag = (uptr)tag;
   FuncEntry(thr, (uptr)caller_pc);
-  MemoryWrite(thr, CALLERPC, (uptr)addr, kSizeLog8);
+  MemoryWrite(thr, CALLERPC, (uptr)addr, kSizeLog1);
   FuncExit(thr);
   thr->external_tag = 0;
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32359.96169.patch
Type: text/x-patch
Size: 729 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170421/cbed56c3/attachment.bin>


More information about the llvm-commits mailing list