[PATCH] D32228: [DWARF] - Take relocations in account when extracting ranges from .debug_ranges

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 21 10:22:06 PDT 2017


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good - check if the test case would be simpler with -gmlt rather than -gsplit-dwarf, and use that if so, otherwise commit whenever you're ready.



================
Comment at: test/DebugInfo/dwarfdump-ranges-unrelocated.s:10
+## Asm code for testcase is a reduced output from next invocation and source:
+# clang test.cpp -S -o test.s -g -gsplit-dwarf -ffunction-sections
+# test.cpp:
----------------
I'd probably not use -gsplit-dwarf in this test case, it doesn't seem to be important/relevant (though I suppose it'll make the DWARF longer as it'll now include all the subprogram DIEs, etc) - maybe -gmlt would suffice?


https://reviews.llvm.org/D32228





More information about the llvm-commits mailing list