[PATCH] D32143: [InstSimplify] use ConstantRange to simplify more and-of-icmps

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 21 06:52:27 PDT 2017


spatel updated this revision to Diff 96132.
spatel added a comment.

Patch updated:
Use "makeExactICmpRegion" rather than "makeAllowedICmpRegion" to avoid a potential bug. As Sanjoy noted, we're using APInt here currently, so there should be no difference right now. But if this code was converted to take ConstantRange inputs, that would be wrong.


https://reviews.llvm.org/D32143

Files:
  lib/Analysis/InstructionSimplify.cpp
  lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
  test/Transforms/InstCombine/and-or-icmps.ll
  test/Transforms/InstCombine/minmax-fold.ll
  test/Transforms/InstSimplify/icmp-ranges.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32143.96132.patch
Type: text/x-patch
Size: 35799 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170421/22571f77/attachment.bin>


More information about the llvm-commits mailing list