[PATCH] D31729: [tsan] Mark "responsible frames" in stack traces to show which frame contains the race

[Dmitry Vyukov via Phabricator via llvm-commits]

dvyukov added a comment.

I am not completely follow motivation for this. Is it meant for user? Or for any automated tools?
For automated tools we already have SUMMARY line. User must be proficient enough to understand what happens. And in the end this is not specific to libc, and the guilty frame is not necessary the one just above libc. Consider a race in std::vector, it's probably not std::vector code that is guilty. And this extends just to any library, consider you have race in libfoo, but it's actually your code that misuses libfoo. We don't have enough info to provide precise signal. What we provide here is a weak, potentially incorrect signal.


Repository:
  rL LLVM

https://reviews.llvm.org/D31729