[PATCH] D31081: [ARM] ScheduleDAGRRList::DelayForLiveRegsBottomUp must consider OptionalDefs

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

I agree with James, refactoring OptionalDef is a task too big for this patch.

However, the patch itself is quite obscure (what lead here). The comment on the code is good, but the test looks like a random sequence of instructions, if you don't see the commit message (because the comment in the code doesn't explain it).

I'd just add the short commit message as a comment to the test, which will explain why we don't want to see an `eors` between the two adds.

Otherwise, LGTM.

Thanks!


https://reviews.llvm.org/D31081