[PATCH] D32335: [PartialInliner] Fix crash when inlining functions with unreachable blocks

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 21:12:33 PDT 2017


davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.

The root cause of the problem is that the partial inliner split the newreturn block unconditionally -- even when there is no PHIs in them (creating unreachable block).   I have included that fix in my patch, but this patch is fine too.

lgtm


https://reviews.llvm.org/D32335





More information about the llvm-commits mailing list