[PATCH] D31837: [cfi] Run tests with and without lld and thinlto.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/cfi/lit.cfg:4
 
-config.name = 'cfi'
+config.name = 'cfi' + config.name_suffix
 config.suffixes = ['.c', '.cpp', '.test']
----------------
eugenis wrote:
> pcc wrote:
> > Why is this change necessary now?
> I can do it in a separate change if you want. Now we have a lot more different configs, so this is becoming important.
> 
> Failing Tests (20):
>     cfi :: cross-dso/icall/dlopen.cpp
>     cfi :: cross-dso/icall/dlopen.cpp
>     cfi :: cross-dso/icall/dlopen.cpp
>     cfi :: cross-dso/icall/dlopen.cpp
>     cfi :: cross-dso/icall/icall-from-dso.cpp
>     cfi :: cross-dso/icall/icall-from-dso.cpp
>     cfi :: cross-dso/icall/icall-from-dso.cpp
>     cfi :: cross-dso/icall/icall-from-dso.cpp
>     cfi :: cross-dso/icall/icall.cpp
>     cfi :: cross-dso/icall/icall.cpp
>     cfi :: cross-dso/icall/icall.cpp
>     cfi :: cross-dso/icall/icall.cpp
>     cfi :: cross-dso/stats.cpp
>     cfi :: cross-dso/stats.cpp
>     cfi :: cross-dso/stats.cpp
>     cfi :: cross-dso/stats.cpp
>     cfi :: icall/external-call.c
>     cfi :: icall/external-call.c
>     cfi :: icall/external-call.c
>     cfi :: icall/external-call.c
> 
> (^ without the change)
I see, this is fine either as part of this change or as a separate change.


Repository:
  rL LLVM

https://reviews.llvm.org/D31837