[PATCH] D32096: Always build libfuzzer

[Kostya Serebryany via llvm-commits]

On Thu, Apr 20, 2017 at 1:06 PM, George Karpenkov <ekarpenkov at apple.com>
wrote:

> Hi Kostya,
>
> What would be a reasonable way to check for its presence?
>>
>
> Frankly, I don't know.
>
>
> A reasonable way would be to use CMake to detect the feature during the
> configuration phase,
> and then generate a variable based on that, which would be later included
> during the compilation.
> That would even improve the current experience, as one would be able to
> compile libFuzzer on a broader range of platforms.
>
> I understand that the ability to compile libFuzzer independently of LLVM
> is important,
>
Not just  independently of LLVM, but independently of anything else,
including cmake.

>> Actually, sorry, just testing with __has_attribute(target) is
sufficient. Changing the build is not required.

Cool!

but that could be still done using CMake, and the libFuzzer repository
> already contains the CMakeLists.txt file.
> What would you think about removing the build script and just using CMake?
> That would just mean two compilation steps instead of one, yet could
> improve applicability.
>
> Cheers,
> George
>
>
>
>
>
>> LLVM webpage currently claims that LLVM should be buildable with those (
>> http://llvm.org/docs/GettingStarted.html#software)
>>
>> There is another failure on http://green.lab.llvm.org/gree
>> n/job/clang-stage1-configure-RA_build/33461/console
>
>
> Yep.
>
>
>>
>>
>> Thanks!
>>
>>
>> Repository:
>>   rL LLVM
>>
>> https://reviews.llvm.org/D32096
>>
>>
>>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170420/fcae1d28/attachment.html>