[PATCH] D32191: Enable lsan by default on 64-bit darwin, and enable lsan test suite
Francis Ricci via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 20 14:07:20 PDT 2017
fjricci added inline comments.
================
Comment at: test/lsan/lit.common.cfg:73
+ and (config.host_os is not 'Darwin' or config.target_arch is not 'x86_64'):
config.unsupported = True
----------------
alekseyshl wrote:
> Too many negatives :) maybe break it up?
>
> supported_linux = config.host_os is 'Linux' and config.host_arch in ['x86_64', 'mips64', 'arm', 'armhf', 'armv7l']
> supported_darwin = config.host_os is 'Darwin' and config.target_arch is 'x86_64'
> if not (supported_linux or supported_darwin):
> config.unsupported = True
Didn't even think to use intermediate variables - will do
https://reviews.llvm.org/D32191
More information about the llvm-commits
mailing list