[PATCH] D32305: [CodeExtractor] Remove a bunch of unneeded constructors

Thu Apr 20 12:01:41 PDT 2017

davide added a comment.

In https://reviews.llvm.org/D32305#732492, @davide wrote:

> In https://reviews.llvm.org/D32305#732439, @davidxl wrote:
>
> > lgtm.
> >
> > by the way,  what is your PM setup for partial inlining?
>
>
> Unfortunately, once I start playing with it, I hit this crash and I started debugging, so I didn't had yet time to put at different places in the pipeline.
>  You have already tried some configurations? Aside, I noticed partial inlining isn't using BB frequency informations (which I found odd, but probably  it's because nobody cared).
>  I imagine at least a simple heuristic where you split functions comparing as GCC does, IIRC (or at least, used to do at some point).

s/comparing/looking at the frequencies of the BBs compared to the frequency of the entry block/
I mean https://gcc.gnu.org/ml/gcc-patches/2010-06/msg02143.html

> There was some initial work on this, but, alas, it's unfinished https://reviews.llvm.org/D22744

Repository:
  rL LLVM

https://reviews.llvm.org/D32305