[PATCH] D32264: [asan] Optimize strchr for strict_string_checks=false

Evgeniy Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 11:21:30 PDT 2017


eugenis added inline comments.


================
Comment at: test/asan/TestCases/strchr_strict.c:51
+  // strict_string_checks=false must not look beyond requested char.
+  protect(p + 1, page_size);
+  r = strchr(s, 'x');
----------------
Returning a PROT_NONE page to the allocator sounds dangerous. Switch to mmap?



https://reviews.llvm.org/D32264





More information about the llvm-commits mailing list