[PATCH] D32276: [AsmWriter/APFloat] FP constant printing: Avoid usage of locale dependent snprinf

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 11:09:13 PDT 2017


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D32276#731864, @skatkov wrote:

> Actually I considered the re-writing llvm::write_double() to be locale independent. I decided to go with solution due to:
>
> 1. to be consistent with Lexer which also uses APFloat


To me, this is a really good reason to do it this way.

Looks good to me. Tim, did you have anything else?


https://reviews.llvm.org/D32276





More information about the llvm-commits mailing list