[PATCH] D32009: Allow attributes with global variables

[Reid Kleckner via Phabricator via llvm-commits]

rnk requested changes to this revision.
rnk added a comment.
This revision now requires changes to proceed.

I don't think we need a new SingleSlotAttributeList type, we already have AttributeSet for that. Feel free to add more helpers to that to implement `addAttribute` etc.



================
Comment at: include/llvm/IR/Attributes.h:550
+template<unsigned Idx>
+class SingleSlotAttributeList {
+  AttributeList Impl;
----------------
How is this not just an AttributeSet, now that we have that?


https://reviews.llvm.org/D32009