[PATCH] D32249: [PartialInl] Enhance partial inliner to handle more complex conditions

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 10:18:00 PDT 2017


wmi added a comment.

I am thinking of another two issues:

1. Is it possible that some of the BBs on the chain may be very big and we don't want to partial inline them?
2. The existing pattern handles if (a || b || c ...) case, but it may not be easy to extend for cases like (a && b && c) and ((a && b) || c). Basically, we want to find a collection of bbs with small sizes starting from entry. The bb collection only have two exits. one of them is ReturnBlock and the other is NonReturnBlock. The edges inside of the collection can be of any pattern.

Sorry I didn't come up with them at the first beginning and dive into details.


https://reviews.llvm.org/D32249





More information about the llvm-commits mailing list