[PATCH] D31951: TableGen support for parametrized register class information

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 08:39:39 PDT 2017


kparzysz added a comment.

In https://reviews.llvm.org/D31951#731960, @asb wrote:

> One question I'd welcome a second opinion on - is the introduction of the `vi::` namespace justified?


Justified?  Good question.  I added some common functions at the top level in VariableValueType.h, and I didn't want to pollute the global name space with them, or at least wanted to make it clearer what these functions are related to.  I'm not convinced that this is an elegant solution, and I'm open to other suggestions.

Thank you for taking time to review all these patches!


Repository:
  rL LLVM

https://reviews.llvm.org/D31951





More information about the llvm-commits mailing list