[PATCH] D32162: Inline asm 0bH conflict

Andrew V. Tischenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 01:41:41 PDT 2017


avt77 added inline comments.


================
Comment at: test/MC/X86/pr27884.s:1
+// RUN: llvm-mc -triple x86_64-unknown-unknown %s
+
----------------
ygao wrote:
> I am not sure whether this test case is supposed to compile cleanly on Linux. Did you test with gnu-as or the latest Intel assembler?
> If someone wants to use binary number on Linux and starts their number with "0b" without the "h" suffix, does it still work with your fix?
Yes, it still works but we should follow gas name conventions:

   4 ???? 48031C25      add 0B10101,    %rbx
   4      15000000
   5 ???? 48031C25      add 0b11100111, %rbx
   5      E7000000
 


https://reviews.llvm.org/D32162





More information about the llvm-commits mailing list