[PATCH] D32259: [XRay] [compiler-rt] - Fix standalone build test and XFAIL a test.

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 19 20:10:20 PDT 2017


dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.

LGTM with one nit.



================
Comment at: test/xray/TestCases/Linux/fdr-thread-order.cc:2
 // RUN: %clangxx_xray -g -std=c++11 %s -o %t
-// RUN: XRAY_OPTIONS="patch_premain=false xray_naive_log=false xray_logfile_base=fdr-thread-order. xray_fdr_log=true verbosity=1" %run %t 2>&1 | FileCheck %s
+// RUN: if compgen -G "fdr-thread-order.*" ; then rm fdr-thread-order.* ; fi
+// RUN: XRAY_OPTIONS="patch_premain=false xray_naive_log=false xray_logfile_base=fdr-thread-order. xray_fdr_log=true verbosity=1 xray_fdr_log_func_duration_threshold_us=0" %run %t 2>&1 | FileCheck %s
----------------
I don't think we can make the assumption that bash is the shell, but unconditionally removing the files anyway would be fine at this point.


https://reviews.llvm.org/D32259





More information about the llvm-commits mailing list