[PATCH] D30107: Make DynamicLibrary::getPermanentLibrary have a defined ordering.
Lang Hames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 19 15:59:32 PDT 2017
lhames added a comment.
Hi Frederich,
Thanks for your patience, and sorry for the long turn-around time on this review.
I had to bring this up to speed with the mainline to test it and while it passed make-check on MacOS I'm seeing test failures on linux:
llvm/unittests/Support/DynamicLibrary/DynamicLibraryTest.cpp:81: Failure
Value of: GS != nullptr && GS == &TestA
Actual: false
Expected: true
llvm/unittests/Support/DynamicLibrary/DynamicLibraryTest.cpp:82: Failure
Expected: StdString(GS())
Which is: "LibCall"
To be equal to: "ProcessCall"
llvm/unittests/Support/DynamicLibrary/DynamicLibraryTest.cpp:85: Failure
Value of: GS != nullptr && GS == &TestA
Actual: false
Expected: true
llvm/unittests/Support/DynamicLibrary/DynamicLibraryTest.cpp:86: Failure
Expected: StdString(GS())
Which is: "LibCall"
To be equal to: "ProcessCall"
Those could be genuine failures, or I could have missed something while updating the patch. Do you have access to a linux box to reproduce these?
Other than that, this all looks good to me. If we can get the tests passing it should be good to go in.
Cheers,
Lang.
https://reviews.llvm.org/D30107
More information about the llvm-commits
mailing list