[PATCH] D32249: [PartialInl] Enhance partial inliner to handle more complex conditions

[David Li via Phabricator via llvm-commits]

davidxl marked an inline comment as done.
davidxl added inline comments.


================
Comment at: lib/Transforms/IPO/PartialInlining.cpp:40
 
+  // Returns the ReturnBlock and NonReturnBlock
+  std::tuple<BasicBlock *, BasicBlock *> findEntryBlocks(Function *F);
----------------
eraman wrote:
> The comments doesn't convey what the function is doing.
Fixed.


================
Comment at: lib/Transforms/IPO/PartialInlining.cpp:50
+  // block as its successor.
+  std::vector<BasicBlock *> Entries_;
   InlineFunctionInfo IFI;
----------------
eraman wrote:
> Why is this named Entries_ and not Entries?
Fixed.


https://reviews.llvm.org/D32249