[PATCH] D32074: [mips] Change the machine verifier to allow nested call sequences.

[Simon Dardis via Phabricator via llvm-commits]

sdardis added a comment.

Hi Sagar,

I don't think this is the correct fix. The issue arising is that the call to memcpy is being generated inside the callseq_start, callseq_end nodes in the DAG. Instead, when we encounter a byval argument, we need to call memcpy outside the sequence. If you check this test with xcore/x86_64/i386/aarch64 you'll see that those targets also call out to memcpy as well. We should look at changing how the arguments are setup for a call in MipsISelLowering.cpp.

The ISD also notes that those callseq nodes are not to be nested.

Thanks,
Simon


Repository:
  rL LLVM

https://reviews.llvm.org/D32074