[lld] r300445 - [ELF] - Add compress-debug-output-i386.s testcase.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 19 04:52:49 PDT 2017


I disagree. As the new code does not depend on the 32/64 difference, we
don't need to have two almost identical tests.

On Wed, Apr 19, 2017 at 4:48 AM, George Rimar <grimar at accesssoftek.com>
wrote:

> > You wrote different code for 32-bit than 64-bit, and that is why you
> needed it. I'm going to fix it and remove this test.
>
> But even with the same or almost the same code, 64 bit header still will
> have ch_reserved field, when
> 32 bit header does not have it. And size of fields will be different
> anyways.
>
> I think we need test for 32 bit at least because of absence of ch_reserved​
> field.
>
> George.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170419/389442df/attachment.html>


More information about the llvm-commits mailing list