[PATCH] D32002: [X86] Improve large struct pass by value performance

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 19 03:00:49 PDT 2017


RKSimon added inline comments.


================
Comment at: test/CodeGen/X86/memcpy-struct-by-value.ll:3
+; RUN: llc -mtriple=x86_64-linux-gnu -mattr=+fast-string < %s -o - | FileCheck %s --check-prefix=ALL --check-prefix=FAST
+
+%struct.large = type { [4096 x i8] }
----------------
RKSimon wrote:
> Include nofast/fast target (-mcpu=) tests as well if possible
You should be able to just use the FAST/NOFAST prefixes, no need for duplicate HASWELL/GENERIC prefixes.

Possibly add tests for IvyBridge as NOFAST (which you haven't enabled yet) and Skylake (which implicitly inherits the feature) as FAST.

Also, should you test on i686-linux-gnu as well?


https://reviews.llvm.org/D32002





More information about the llvm-commits mailing list