[PATCH] D32202: [XRay][compiler-rt] Fix up CFI annotations and stack alignment

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 23:57:09 PDT 2017


dberris added a comment.

In https://reviews.llvm.org/D32202#730098, @dberris wrote:

> In https://reviews.llvm.org/D32202#730089, @eugenis wrote:
>
> > FunctionEntry does not look right. It has the frame of 216 bytes (return address + rbp + 184), which is not a multiple of 16. The same with ArgLoggerEntry.
>
>
> So adjusting this just another 8 bytes artificially would be fine, yes?


Looked into this a bit more and because rbp + 184 + address is really just 208, we're fine (it's 16-byte aligned ).

I have a change coming taking into account the comments by @kpw and @pelikan as well.


Repository:
  rL LLVM

https://reviews.llvm.org/D32202





More information about the llvm-commits mailing list