[compiler-rt] r300593 - Don't use abort_on_error for lsan darwin test suite

Francis Ricci via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 13:56:59 PDT 2017


Author: fjricci
Date: Tue Apr 18 15:56:59 2017
New Revision: 300593

URL: http://llvm.org/viewvc/llvm-project?rev=300593&view=rev
Log:
Don't use abort_on_error for lsan darwin test suite

Summary:
This option is disabled by our other test suites, and will cause
failures when unit tests abort instead of failing with an error code.
Will also prevent the test suite from being too slow.

Reviewers: kubamracek, alekseyshl

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D32129

Modified:
    compiler-rt/trunk/test/lsan/lit.common.cfg

Modified: compiler-rt/trunk/test/lsan/lit.common.cfg
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/lsan/lit.common.cfg?rev=300593&r1=300592&r2=300593&view=diff
==============================================================================
--- compiler-rt/trunk/test/lsan/lit.common.cfg (original)
+++ compiler-rt/trunk/test/lsan/lit.common.cfg Tue Apr 18 15:56:59 2017
@@ -34,6 +34,13 @@ config.name += config.name_suffix
 
 # Platform-specific default LSAN_OPTIONS for lit tests.
 default_lsan_opts = ''
+if config.host_os == 'Darwin':
+  # On Darwin, we default to `abort_on_error=1`, which would make tests run
+  # much slower. Let's override this and run lit tests with 'abort_on_error=0'.
+  # Also, make sure we do not overwhelm the syslog while testing.
+  default_lsan_opts = 'abort_on_error=0'
+  default_lsan_opts += ':log_to_syslog=0'
+
 if default_lsan_opts:
   config.environment['LSAN_OPTIONS'] = default_lsan_opts
   default_lsan_opts += ':'




More information about the llvm-commits mailing list