[PATCH] D32165: Implement suspended thread register count for darwin

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 11:28:54 PDT 2017


kubamracek added a comment.

Can we also get an implementation of GetRegistersAndSP?  It's hard to see where this patch is heading without the implementation of GetRegistersAndSP.

But if there's something blocking GetRegistersAndSP, then this looks okay to me.



================
Comment at: lib/sanitizer_common/sanitizer_stoptheworld_mac.cc:16-17
 
 #if SANITIZER_MAC && (defined(__x86_64__) || defined(__aarch64__) || \
                       defined(__mips64) || defined(__i386))
 
----------------
Btw, do we still need __mips64 here?  Darwin certainly doesn' support MIPS...


https://reviews.llvm.org/D32165





More information about the llvm-commits mailing list