[PATCH] D31530: [ARM] Use new assembler diags for ARM

Oliver Stannard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 05:53:19 PDT 2017


olista01 added a comment.

Thanks, could you also review https://reviews.llvm.org/D27620, which this depends on?

> I guess this will be a long road anyway, so we should cope with some vague messages now, and add better ones with time.

Yep, my plan was to get this change in without regressing anything too badly, then add diagnostics for each operand and register class. I've got a few patches that build on this up in phab, but I'm currently hitting a problem caused by the shouldOmitCCOutOperand function in the ARMAsmParser causing many instructions to fail to match all of their operands, not just the visible one. Once I've found a good solution to that, adding diags will hopefully only require adding the diagnostic string in the tablegen description of the operand.


Repository:
  rL LLVM

https://reviews.llvm.org/D31530





More information about the llvm-commits mailing list