[PATCH] D32155: [APInt] Use lshrInPlace to replace lshr where possible

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 04:00:26 PDT 2017


RKSimon added inline comments.


================
Comment at: include/llvm/ADT/APInt.h:892
   /// Logical right-shift this APInt by ShiftAmt in place.
-  void lshrInPlace(unsigned ShiftAmt);
+  APInt &lshrInPlace(unsigned ShiftAmt);
 
----------------
Other than operators we don't tend to use this pattern to return *this - is it a good idea to introduce it?


https://reviews.llvm.org/D32155





More information about the llvm-commits mailing list