[PATCH] D32160: [ARM] Rename HW div feature to HW div Thumb. NFCI.

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 03:30:43 PDT 2017


rovka created this revision.
Herald added subscribers: rengolin, aemerson.

The hardware div feature refers only to Thumb, but because of its name
it is tempting to use it to check for hardware division in general, which
may cause problems in ARM mode. See https://reviews.llvm.org/D32005.

This patch adds "Thumb" to its name, to make its scope clear. One
notable place where I haven't made the change is in the feature flag
(used with -mattr), which is still hwdiv. Changing it would also require
changes in a lot of tests, including clang tests, and it doesn't seem
like it's worth the effort.


https://reviews.llvm.org/D32160

Files:
  include/llvm/Support/ARMTargetParser.def
  include/llvm/Support/TargetParser.h
  lib/Support/TargetParser.cpp
  lib/Target/ARM/ARM.td
  lib/Target/ARM/ARMAsmPrinter.cpp
  lib/Target/ARM/ARMFastISel.cpp
  lib/Target/ARM/ARMISelLowering.cpp
  lib/Target/ARM/ARMInstrInfo.td
  lib/Target/ARM/ARMInstrThumb2.td
  lib/Target/ARM/ARMSubtarget.h
  lib/Target/ARM/AsmParser/ARMAsmParser.cpp
  unittests/Support/TargetParserTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32160.95547.patch
Type: text/x-patch
Size: 34777 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170418/4f649758/attachment.bin>


More information about the llvm-commits mailing list