[PATCH] D31439: PR32382: Emit complex DWARF expressions with the correct location description kind

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 17 16:20:28 PDT 2017


aprantl requested review of this revision.
aprantl added a comment.

David, the review is still marked as accepted, but I did add a couple of changes since then, so I think I should be moving it back into "Request review".
Would you mind taking a second look?

As I mentioned in the description, all IR testcases that were modified were regenerated from clang. I also added source-based testcases for each of these to the debuginfo-tests repository over the last week to make sure that no synchronized bugs slip in. The debuginfo-tests compile from source and run the debugger and are exercised by the green dragon bots, so all these changes should be safe.
thanks!
adrian


https://reviews.llvm.org/D31439





More information about the llvm-commits mailing list