[PATCH] D31524: Add a linker script to version LLVM symbols

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: cmake/modules/AddLLVM.cmake:85
     add_custom_command(OUTPUT ${native_export_file}
-      COMMAND echo "{" > ${native_export_file}
+      COMMAND echo "LLVM_${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR} {" > ${native_export_file}
       COMMAND grep -q "[[:alnum:]]" ${export_file} && echo "  global:" >> ${native_export_file} || :
----------------
sylvestre.ledru wrote:
> rnk wrote:
> > sylvestre.ledru wrote:
> > > rnk wrote:
> > > > Is this correct for DSOs that aren't libLLVM.so.N.M? This function is called from LLDB and elsewhere.
> > > It doesn't have too. libLLVM.so.N.M is for the SONAME.
> > > However, I can rename it, no worries
> > So, this doesn't refer to LLVM the DSO, it refers to LLVM the project. After this change, libclang.so will have symbols with LLVM_N.M as their version, right?
> Yes, I can rename it to LLVM_TOOLCHAIN_N.M if you prefer but this is a bit long.
> 
No, it's fine. Maybe add a comment, since I don't think ELF version script details are common knowledge.


Repository:
  rL LLVM

https://reviews.llvm.org/D31524