[PATCH] D31947: [scudo] Android support groundwork

Evgeniy Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 17 13:32:50 PDT 2017


eugenis added inline comments.


================
Comment at: lib/scudo/scudo_allocator.cpp:317
+                 bool ForceZeroContents = false) {
+    initThreadMaybe();
+    if (UNLIKELY(!IsPowerOfTwo(Alignment))) {
----------------
Calling initThreadMaybe() from all entry points looks error-prone. Is it ok (performance-wise) to do lazy initialization in getCurrentThreadContext?


================
Comment at: lib/scudo/scudo_thread.h:10
+///
+/// TODO(kostyak): description.
+///
----------------
an actual description would be nice


https://reviews.llvm.org/D31947





More information about the llvm-commits mailing list