[PATCH] D32130: Move valid caller-pc checks out of platform-specific checks

Francis Ricci via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 17 11:07:04 PDT 2017


fjricci created this revision.

ProcessPlatformSpecificAllocations for linux leak sanitizer iterated over
memory chunks and ran two checks concurrently:

1. Ensured the pc was valid
2. Checked whether it was a linker allocation

All platforms will need the valid pc check, so it is moved out of the platform-
specific file. To prevent code and logic duplication, the linker allocation
check is moved as well, with the name of the linker supplied by the platform-specific
module. In cases where we don't need to check for linker allocations (ie Darwin),
this name will be a nullptr, and we'll only run the caller pc checks.


https://reviews.llvm.org/D32130

Files:
  lib/lsan/lsan_common.cc
  lib/lsan/lsan_common.h
  lib/lsan/lsan_common_linux.cc
  lib/lsan/lsan_common_mac.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32130.95459.patch
Type: text/x-patch
Size: 8404 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170417/6f885981/attachment.bin>


More information about the llvm-commits mailing list