[PATCH] D32082: [ELF] - Implemented --defsym option

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 17 00:16:37 PDT 2017


grimar added a comment.

In https://reviews.llvm.org/D32082#727317, @ruiu wrote:

> This doesn't look good as you changed too many places for this little feature. Do you really have to support expressions that contain operators? I think you can start with supporting an assignments that consist of only two symbols in the form of -defsym=<sym1>=<sym2>.


Ok, I just was interested if our linkerscript parsing code can be easily adopted to use for this option. I read your comment in PR32350, you wrote it's "tricky", I was interested "how much" :)
So if it is too much I'll prepare separate patch for simpler cases (1 and/or 3 from your comment).


https://reviews.llvm.org/D32082





More information about the llvm-commits mailing list