[PATCH] D32027: [Polly][DeLICM] Use Known information when comparing Existing.Written and Proposed.Written. NFC.

[Tobias Grosser via Phabricator via llvm-commits]

grosser accepted this revision.
grosser added a comment.
This revision is now accepted and ready to land.

Hi Michael,

this looks good to me. Could you possibly still add one test case where both Expected and Proposed map to '{}'. I also have two small ideas how the code could been written a little bit simpler. Nothing serious. Feel free to apply them or not. Otherwise, this looks all fine.

(I also would not call this NFC)



================
Comment at: lib/Transform/DeLICM.cpp:425
+  return Result;
+}
+
----------------
This could possibly be written simpler as

UMap = UMap.subtract_range(makeUnknown());

assuming we introduce a makeUnknown() function.


================
Comment at: lib/Transform/DeLICM.cpp:788
+                             .intersect(filterKnownValInst(Proposed.Written))
+                             .domain();
+
----------------
If you intersect before filtering, you just need to apply the filter once.


https://reviews.llvm.org/D32027