[PATCH] D30879: Distinguish between code pointer size and DataLayout::getPointerSize() in DWARF info generation

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 14 12:44:36 PDT 2017


kzhuravl added inline comments.


================
Comment at: test/DebugInfo/AMDGPU/variable-locations.ll:31
 ; CHECK-NEXT: DW_AT_decl_line
-; CHECK-NEXT: DW_AT_location [DW_FORM_block1] (<0x05> 03 00 00 00 00 )
 @GlobB = common addrspace(1) global i32 0, align 4, !dbg !6
----------------
kzhuravl wrote:
> mehdi_amini wrote:
> > These were buggy before?
> Yes.
This patch also fixes AMDGPU's code pointer size (see AMDGPUMCAsmInfo.cpp), resulting in this test change. Should AMDGPU's fix remain in this patch or be moved to a separate patch?


https://reviews.llvm.org/D30879





More information about the llvm-commits mailing list