[PATCH] D31941: [ELF] - Implemented --compress-debug-sections option.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 14 11:29:52 PDT 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM

There is a room for improvements, but I'll do that after you submit this.



================
Comment at: ELF/OutputSections.cpp:99-109
+  if (Config->Is64) {
+    Buf += sizeof(Elf64_Word); // Skip ch_reserved field.
+    write64<E>(Buf, Size);
+    Buf += sizeof(Elf64_Xword);
+    write64<E>(Buf, Alignment);
+    Buf += sizeof(Elf64_Xword);
+  } else {
----------------
You are not accessing these members by name.


https://reviews.llvm.org/D31941





More information about the llvm-commits mailing list