[llvm] r300339 - Remove "#if 0"ed out assert

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 14 09:47:15 PDT 2017


Author: sanjoy
Date: Fri Apr 14 11:47:15 2017
New Revision: 300339

URL: http://llvm.org/viewvc/llvm-project?rev=300339&view=rev
Log:
Remove "#if 0"ed out assert

It won't compile after the recent changes I've made, and I think
keeping it in provides very little value.

Instead I've added (in an earlier commit) a C++ unit test to check the
Denormalize(Normalized(X)) == X property for specific instances of X,
which is what the assert was trying to do anyway.

Modified:
    llvm/trunk/lib/Analysis/ScalarEvolutionNormalization.cpp

Modified: llvm/trunk/lib/Analysis/ScalarEvolutionNormalization.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ScalarEvolutionNormalization.cpp?rev=300339&r1=300338&r2=300339&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/ScalarEvolutionNormalization.cpp (original)
+++ llvm/trunk/lib/Analysis/ScalarEvolutionNormalization.cpp Fri Apr 14 11:47:15 2017
@@ -83,11 +83,6 @@ static const SCEV *transformImpl(const T
             transformSubExpr(Kind, Pred, SE, Cache, AR->getStepRecurrence(SE));
         Result = SE.getMinusSCEV(Result, TransformedStep);
       }
-#if 0
-      // See the comment on the assert above.
-      assert(S == transformSubExpr(Result, User, OperandValToReplace) &&
-             "SCEV normalization is not invertible!");
-#endif
       break;
     case Denormalize:
       // Here we want to normalize step expressions for the same reasons, as




More information about the llvm-commits mailing list