[PATCH] D32023: [ProfileData] Support coverage for PE binaries

[Xinliang David Li via llvm-commits]

My pending patch (under review) is supposed to fix this failure.

David


On Fri, Apr 14, 2017 at 9:43 AM, Reid Kleckner via Phabricator <
reviews at reviews.llvm.org> wrote:

> rnk added inline comments.
>
>
> ================
> Comment at: llvm/trunk/include/llvm/ProfileData/InstrProfData.inc:666
> +
> +#ifdef _WIN32
>  /* Runtime section names and name strings.  */
> ----------------
> This ifdef breaks cross compiling. In particular,
> llvm/test/Instrumentation/InstrProfiling/X86/alloc.ll is failing on
> Windows since this change. LLVM should choose the section name at runtime
> based on the target triple, not the host defines.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D32023
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170414/e07febb8/attachment.html>