[PATCH] D31539: Hoisting invariant.group in LICM

Piotr Padlewski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 14 07:18:57 PDT 2017


Prazek planned changes to this revision.
Prazek added a comment.

Few problems that I have to address before it will make sense to hoist based on invariant.group

1a. We should preserve the metadata if we are not speculatively hoisting loads (if it is guaranteed to execute). This way we won't gonna loose invariant.group metadata that is crucial to preserve
1b. with 1a we should only hoist invariant.group instructions if we will preserve the metadata

2. We have to find a way to preserve the metadata if we want to hoist speculatively - I proposed solution on mailing list, and there is also very close one here https://reviews.llvm.org/D18738


https://reviews.llvm.org/D31539





More information about the llvm-commits mailing list