[PATCH] D32025: [Polly][DeLICM] Use Known information when comparing Existing.Occupied and Proposed.Occupied. NFC.

Tobias Grosser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 14 06:59:07 PDT 2017


grosser added a comment.

Hi Michael,

it also seems as if as part of this commit and the next two commits you exploit more of the new isl C++ bindings in isConflicting. It might make sense to just have a first [NFC] which switches the complete function over and commit this change ahead of time. In general, after the C++ bindings are now mostly through, it seems we can be more free in moving parts of Polly over. At least from my perspective, patches that just move parts of Polly step by step to the new bindings are in such obvious cases as here probably OK to commit even without pre-commit review.


https://reviews.llvm.org/D32025





More information about the llvm-commits mailing list